Skip to content

Remove scrollIntoView for activeTab #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2024
Merged

Remove scrollIntoView for activeTab #5000

merged 1 commit into from
Oct 12, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 12, 2024 •
edited by pr-codex bot
Loading

Its creating issues with scrolling on iOS

PR-Codex overview

This PR focuses on modifying the transition effects for a tab component in the tabs.tsx file, specifically enhancing the visual behavior when a tab is activated.

Detailed summary

  • Added a transition effect to lineEl for transform and width over 0.3s.
  • Removed the scrollIntoView method call with smooth behavior for the active tab element.
  • Set the width of lineRef.current to 0px when no active tab is present.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f9f5365

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 5:58am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 12, 2024 5:58am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 12, 2024 5:58am
wallet-ui ⬜️ Skipped (Inspect) Oct 12, 2024 5:58am

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 12, 2024 04:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 12, 2024 04:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 12, 2024 04:13 Inactive
@MananTank MananTank marked this pull request as ready for review October 12, 2024 04:13
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 12, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.76%. Comparing base (79f029c) to head (f9f5365).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5000   +/-   ##
=======================================
  Coverage   47.76%   47.76%           
=======================================
  Files        1058     1058           
  Lines       57290    57290           
  Branches     3943     3943           
=======================================
  Hits        27364    27364           
  Misses      29235    29235           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 79f029c
packages 43.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 4.9 s (+118.65% 🔺) 5.8 s
thirdweb (cjs) 101.87 KB (0%) 2.1 s (0%) 5.2 s (+1.14% 🔺) 7.2 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 546 ms (+161.16% 🔺) 643 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 80 ms (-7.73% 🔽) 90 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 362 ms (-41.47% 🔽) 707 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 12, 2024 •
edited by MananTank
Loading

Merge activity

@MananTank
Remove scrollIntoView for activeTab (#5000)
f9f5365 
Its creating issues with scrolling on iOS
@MananTank MananTank force-pushed the 10-12-remove_scrollintoview_for_activetab branch from 4202e7d to f9f5365 Compare October 12, 2024 05:56
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 12, 2024 05:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 12, 2024 05:56 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 12, 2024 05:56 Inactive
@graphite-app graphite-app bot merged commit f9f5365 into main Oct 12, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 10-12-remove_scrollintoview_for_activetab branch October 12, 2024 05:59
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 12, 2024 05:59 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 12, 2024 05:59 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 12, 2024 05:59 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls